Page MenuHomeFreeBSD
Projects Contributor Reviews (src)

Contributor Reviews (src)Project
ActivePublic
Watch Project

Members (11)

Watchers (4)

Recent Activity
View All

Apr 7 2024

lwhsu added a reviewer for D44667: vm_reserv_reclaim_contig: Return NULL not false: markj.
Apr 7 2024, 6:11 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D44667: vm_reserv_reclaim_contig: Return NULL not false.

I'm not completely familar with FreeBSD's virtual memory system. But it seems the comment still doesn't match the code. Doesn't it return m_ret when the reclaim is successful and null when failed?

Apr 7 2024, 5:51 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the test plan for D44667: vm_reserv_reclaim_contig: Return NULL not false.
Apr 7 2024, 5:45 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D44664: stdbool.h: Update for C23.

Removed redundant macros

Apr 7 2024, 4:27 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added inline comments to D44664: stdbool.h: Update for C23.
Apr 7 2024, 4:23 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added inline comments to D44665: stddef.h: Update for C23.
Apr 7 2024, 4:20 AM · Contributor Reviews (src)
imp accepted D44666: sys/types.h: Do not define bool macros for C23 and later.
Apr 7 2024, 3:43 AM · Contributor Reviews (src)
imp requested changes to D44665: stddef.h: Update for C23.
Apr 7 2024, 3:41 AM · Contributor Reviews (src)
imp requested changes to D44664: stdbool.h: Update for C23.
Apr 7 2024, 3:38 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44666: sys/types.h: Do not define bool macros for C23 and later: Contributor Reviews (src).
Apr 7 2024, 3:15 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44665: stddef.h: Update for C23: Contributor Reviews (src).
Apr 7 2024, 3:10 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D44664: stdbool.h: Update for C23.

Add __STDC_VERSION_STDBOOL_H__ as the header file now conforms C23.

Apr 7 2024, 2:21 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44664: stdbool.h: Update for C23: Contributor Reviews (src).
Apr 7 2024, 2:11 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D44663: stdalign.h: Disable for C23.

Fix grammar in the commit message

Apr 7 2024, 1:02 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44663: stdalign.h: Disable for C23: Contributor Reviews (src).
Apr 7 2024, 1:01 AM · Contributor Reviews (src)

Apr 6 2024

minsoochoo0122_proton.me abandoned D44660: llvm-project: Fix build on devel/llvm18.

Fixed by 5f757f3ff9144b609b3c433dfd370cc6bdc191ad and cb14a3fe5122c879eae1fb480ed7ce82a699ddb6

Apr 6 2024, 11:29 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D44660: llvm-project: Fix build on devel/llvm18.

When will we merge the upstream llvm-project to freebsd-src? Are there any issues blocking the merge?

Apr 6 2024, 9:54 PM · Contributor Reviews (src)
lwhsu added a reviewer for D44660: llvm-project: Fix build on devel/llvm18: brooks.
Apr 6 2024, 8:58 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D44660: llvm-project: Fix build on devel/llvm18.
Apr 6 2024, 7:56 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44660: llvm-project: Fix build on devel/llvm18: Contributor Reviews (src).
Apr 6 2024, 7:55 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43239: Use gnu17 for buildkernel.

Fixed macro

Apr 6 2024, 3:16 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43254: libc: Remove support for pre-C11 C standards.

@jrtc27 Can you review the changes?

Apr 6 2024, 12:40 AM · Contributor Reviews (src)

Mar 26 2024

rozhuk.im-gmail.com abandoned D11140: OSS: allow unplug sound cards without apps close devices.
Mar 26 2024, 6:27 AM · Contributor Reviews (src), multimedia
christos added a comment to D11140: OSS: allow unplug sound cards without apps close devices.

D43545 takes care of this change. Should we close this?

Mar 26 2024, 5:49 AM · Contributor Reviews (src), multimedia

Mar 11 2024

minsoochoo0122_proton.me added a comment to D43239: Use gnu17 for buildkernel.

Are there any more changes required?

Mar 11 2024, 5:42 AM · Contributor Reviews (src)

Feb 29 2024

emaste accepted D44145: Disable C standards under C99 from kernel build.
Feb 29 2024, 9:57 PM · Contributor Reviews (src)
emaste added inline comments to D44145: Disable C standards under C99 from kernel build.
Feb 29 2024, 9:57 PM · Contributor Reviews (src)
imp added inline comments to D44145: Disable C standards under C99 from kernel build.
Feb 29 2024, 6:11 PM · Contributor Reviews (src)
imp added a comment to D44145: Disable C standards under C99 from kernel build.

Thanks for splitting this out.

Feb 29 2024, 6:08 PM · Contributor Reviews (src)
imp accepted D44145: Disable C standards under C99 from kernel build.
Feb 29 2024, 6:08 PM · Contributor Reviews (src)

Feb 28 2024

minsoochoo0122_proton.me added inline comments to D43254: libc: Remove support for pre-C11 C standards.
Feb 28 2024, 11:46 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D44145: Disable C standards under C99 from kernel build.
Feb 28 2024, 11:46 PM · Contributor Reviews (src)
minsoochoo0122_proton.me retitled D43254: libc: Remove support for pre-C11 C standards from Remove support for pre-C11 C standards to libc: Remove support for pre-C11 C standards.
Feb 28 2024, 11:43 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43254: libc: Remove support for pre-C11 C standards.

Separate commit

Feb 28 2024, 11:43 PM · Contributor Reviews (src)
emaste added inline comments to D43254: libc: Remove support for pre-C11 C standards.
Feb 28 2024, 3:57 PM · Contributor Reviews (src)
emaste accepted D43237: Use gnu17 for buildworld.
Feb 28 2024, 2:54 PM · Contributor Reviews (src)

Feb 4 2024

minsoochoo0122_proton.me added a reviewer for D43730: vm: Convert boolean_t to bool: Contributor Reviews (src).
Feb 4 2024, 9:50 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D43742: rpcsvc/yp_prot.h: remove redundant definition of bool: Contributor Reviews (src).
Feb 4 2024, 9:49 PM · Contributor Reviews (src)
markj closed D43729: pmap: Reflect 1f1b228 in man page.
Feb 4 2024, 1:54 AM · Contributor Reviews (src)
markj closed D43726: libc: Specify parameter types for function pointer.
Feb 4 2024, 1:54 AM · Contributor Reviews (src)

Feb 3 2024

dab accepted D43726: libc: Specify parameter types for function pointer.
Feb 3 2024, 11:53 PM · Contributor Reviews (src)
minsoochoo0122_proton.me retitled D43726: libc: Specify parameter types for function pointer from libc: Specify paremeter types for function pointer to libc: Specify parameter types for function pointer.
Feb 3 2024, 11:49 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43726: libc: Specify parameter types for function pointer.

Fixed typo in commit message

Feb 3 2024, 11:49 PM · Contributor Reviews (src)
dab added a comment to D43726: libc: Specify parameter types for function pointer.

A nit on the description: "paremeter" should be "parameter"

Feb 3 2024, 11:46 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43729: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 11:24 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D43726: libc: Specify parameter types for function pointer: Contributor Reviews (src).
Feb 3 2024, 9:55 PM · Contributor Reviews (src)
markj closed D43715: ctfmerge: remove function cast of strcompare() for qsort().
Feb 3 2024, 7:10 PM · Contributor Reviews (src)
markj closed D43722: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 7:10 PM · Contributor Reviews (src)
mhorne accepted D43722: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 6:51 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43722: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 6:07 PM · Contributor Reviews (src)