yeah, without it the ampdu retry stuff eventually stops retrying until the counter loops around again for the comparison to work

I don't get the correlation between your commit message and these changes. Is there an actual change (due to casting) in this change? Or is there a problem "somewhere" but this change does not necessarily address that?

Your first line of commit message is RX repetitive; I assume one should be tx. Should be fixed before commit.

Changes:

• Removed unnecessary TSF insertion in probe response frames
• Removed pause() workaround for wpa_supplicant(8) race condition
• Added ic_cryptocaps configuration to declare supported cipher suites

Can you please create diffs with -U9999 if you manually upload them so there is context?

It wasn't clear from out last conversation if this is ready for review or if there is more related work.

more cleanups, inspired by bz's poking at this whole rssi/nf/signal strength cleanup.

Just dropping a note that this leads to ~10x throughput to pkg.f.o on my laptop -- previously averaging somewhere around ~2-3mbit/s due to constant out-of-order acks, up to ~25-30 mbit/s on average

Are you sure you are not getting full reassembled (re-aggregated) frames on your AX210 that better sees no sequence number checks in net80211 anymore?

Just see https://reviews.freebsd.org/D50929

@bz here's another great example of "almost but not quite what net80211 "expects" " ;-) sigh.. :)

comments from bz

Seems fine ..

I am reluctant to click on Request Changes for this but maybe you can still fix the local bits before committing.

Please update the bits available comment below keymgmt when you land this

Looks good to me

more "correct" fixes, i hope!