mbuf: Remove UDP_IPV4_EX, which is never defined.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Sep 22 2017, 5:36 AM.

Details

Reviewers

rwatson
adrian
gallatin
freebsd-net-list
glebius

Commits

rS324052: mbuf: Remove UDP_IPV4_EX, which was never defined.

Summary

Add comment to explain the IPV6_EX suffix.  The confusion about
these RSS hash type probably stems from the facts that they were
never widely implemented by hardwares.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sepherosa_gmail.com created this revision.Sep 22 2017, 5:36 AM

This seems generally sensible.

I'm not quite sure about keeping the "Non-standard RSS hash types" comment, as M_HASHTYPE_OPAQUE is basically intended to be a catch-all for any other model, and is not specifically intended to be RSS (hence not having RSS in its name). So I'd be tempted to drop that comment.

This revision is now accepted and ready to land.Sep 22 2017, 12:21 PM

In D12453#258240, @rwatson wrote:

This seems generally sensible.

I'm not quite sure about keeping the "Non-standard RSS hash types" comment, as M_HASHTYPE_OPAQUE is basically intended to be a catch-all for any other model, and is not specifically intended to be RSS (hence not having RSS in its name). So I'd be tempted to drop that comment.

OK, sure.

Closed by commit rS324052: mbuf: Remove UDP_IPV4_EX, which was never defined. (authored by sephe). · Explain WhySep 27 2017, 6:31 AM

This revision was automatically updated to reflect the committed changes.