Page MenuHomeFreeBSD
Feed Search

Search
Use Results
Hide Query

Feb 25 2026

dab committed rG42ab99095b7d: procstat: CID 1593951: Resource leak.
Feb 25 2026, 11:11 PM

Dec 7 2025

dab accepted D51383: nvme: Add child device for each controller.
Dec 7 2025, 5:16 PM
dab accepted D51386: nvme: Nvme controller generated events.
Dec 7 2025, 5:14 PM
dab accepted D51387: nvme_sim: Connect to events broadcast with nvme_if.
Dec 7 2025, 5:12 PM
dab accepted D51390: nvme: Use new method to do async notifications.
Dec 7 2025, 5:03 PM
dab accepted D51391: nvme: Notify failure with newbus call.
Dec 7 2025, 5:02 PM
dab accepted D54095: nvme: remove now-redundant consumer interface.
Dec 7 2025, 5:01 PM

Oct 12 2025

dab accepted D53036: stand/i386: quiet gcc -Warray-bounds.
Oct 12 2025, 2:32 PM
dab accepted D52867: nvd.4: Add a HARDWARE section for HW Relnotes.
Oct 12 2025, 2:25 PM

Sep 21 2025

dab accepted D52500: stand: Try to parse vdisk correctly.
Sep 21 2025, 11:11 PM

Jan 24 2025

dab accepted D48456: nvmecontrol: Only do name resolution once for Fabrics connections.
Jan 24 2025, 1:12 AM

Jan 19 2025

dab closed D48439: stand/efihttp: Add device type check to efihttp_fs_open().
Jan 19 2025, 5:01 PM
dab committed rG2f35419fb26d: stand/efihttp: Add device type check to efihttp_fs_open() (authored by yongbo.yao_dell.com).
Jan 19 2025, 5:01 PM
dab accepted D48218: nvme/nvmf: Add NVME_GET_CONTROLLER_DATA ioctl to fetch cached cdata.
Jan 19 2025, 3:10 AM

Jan 18 2025

dab requested changes to D48456: nvmecontrol: Only do name resolution once for Fabrics connections.
Jan 18 2025, 1:46 AM

Jan 13 2025

dab accepted D48439: stand/efihttp: Add device type check to efihttp_fs_open().
Jan 13 2025, 2:08 PM
dab committed R9:291e355b2162: Re-add my (updated) PGP key.
Jan 13 2025, 12:53 AM

Jan 9 2025

dab committed rG7c94d515db90: aio_kqueue_test: Fix CID 1558429.
Jan 9 2025, 2:44 PM
dab closed D48328: aio_kqueue_test: Fix CID 1558429.
Jan 9 2025, 2:43 PM
dab updated the diff for D48328: aio_kqueue_test: Fix CID 1558429.

Change to using an assert

Jan 9 2025, 1:34 PM

Jan 8 2025

dab added a comment to D48328: aio_kqueue_test: Fix CID 1558429.
In D48328#1102276, @asomers wrote:

I think this is OK. But it would also be fine just to put an assert(j < max_queue_per_proc before the array dereference.

Jan 8 2025, 2:19 AM

Jan 5 2025

dab published D48328: aio_kqueue_test: Fix CID 1558429 for review.
Jan 5 2025, 8:05 PM

Nov 6 2024

dab accepted D47444: Use correct idle routine on AMD.
Nov 6 2024, 7:45 PM

May 11 2024

dab accepted D45153: nvme/f: Use strlcpy instead of strncpy + manual string termination.
May 11 2024, 1:46 AM
dab accepted D45152: nvme: Use strlcpy instead of strncpy to ensure termination.
May 11 2024, 1:45 AM

Feb 9 2024

dab committed rG70450ecd37fa: ntb: Add Intel Xeon Gen4 support (authored by austin.zhang_dell.com).
Feb 9 2024, 4:50 PM

Feb 3 2024

dab accepted D43726: libc: Specify parameter types for function pointer.
Feb 3 2024, 11:53 PM · Contributor Reviews (src)
dab accepted D43714: loader: For EFI, if we don't have ConOut, try ConIn.
Feb 3 2024, 11:49 PM
dab added a comment to D43726: libc: Specify parameter types for function pointer.

A nit on the description: "paremeter" should be "parameter"

Feb 3 2024, 11:46 PM · Contributor Reviews (src)
dab added inline comments to D43701: loader: Document the lua loader table..
Feb 3 2024, 11:42 PM

Dec 31 2023

dab accepted D43241: rc.initdiskless: Remove bogus plus sign.
Dec 31 2023, 6:12 PM
dab accepted D43193: nvmem: Move nvmem code in dev/nvmem.
Dec 31 2023, 6:11 PM

Dec 28 2023

dab accepted D43193: nvmem: Move nvmem code in dev/nvmem.

LGTM

Dec 28 2023, 3:54 PM
dab accepted D43201: cam: Let cam_periph_unmapmem() return an error.

LGTM

Dec 28 2023, 3:52 PM

Nov 10 2023

dab accepted D42530: kern linker: Do not try to unload kernel.
Nov 10 2023, 2:07 AM
dab accepted D42527: kern linker: Do not try to unload module if it has dependants.
Nov 10 2023, 2:04 AM

May 30 2023

dab accepted D40236: Fix NULL deref in ip_output during route change.
May 30 2023, 3:04 PM

Feb 23 2023

dab committed rG3ff497061b33: Fix Coverity issue in the NVDIMM driver (authored by robert.herndon_dell.com).
Feb 23 2023, 2:43 AM
dab closed D38676: Fix Coverity issue in the NVDIMM driver.
Feb 23 2023, 2:43 AM

Feb 19 2023

dab requested review of D38676: Fix Coverity issue in the NVDIMM driver.
Feb 19 2023, 8:31 PM

Feb 16 2023

dab committed rGb086426bc210: hyperv: Fix Coverity issues in the Hyper-V driver (authored by robert.herndon_dell.com).
Feb 16 2023, 2:24 AM
dab closed D38551: hyperv: Fix Coverity issues in the Hyper-V driver.
Feb 16 2023, 2:24 AM

Feb 14 2023

dab updated the diff for D38551: hyperv: Fix Coverity issues in the Hyper-V driver.

Correct author in commit log.

Feb 14 2023, 4:51 PM
dab added a comment to D38551: hyperv: Fix Coverity issues in the Hyper-V driver.
In D38551#877968, @vangyzen wrote:

Common practice for attributing the submitter with git is:

git commit --amend --author='Robert Herndon <Robert.Herndon@Dell.com>'

Feb 14 2023, 4:28 PM
dab added a reviewer for D38551: hyperv: Fix Coverity issues in the Hyper-V driver: michael.baptist_dell.com.
Feb 14 2023, 2:48 PM

Feb 12 2023

dab updated the diff for D38551: hyperv: Fix Coverity issues in the Hyper-V driver.

Re-submit

Feb 12 2023, 11:27 PM
dab requested review of D38551: hyperv: Fix Coverity issues in the Hyper-V driver.
Feb 12 2023, 11:21 PM

Apr 12 2022

dab committed rG0966fb1b74b3: Extend the length of dirpath to fix failure in kyua test.
Apr 12 2022, 4:27 PM
dab closed D34885: Extending the length of dirpath to fix the failure in kyua test sys/audit/inter-process:shm_unlink_success.
Apr 12 2022, 4:27 PM
dab commandeered D34885: Extending the length of dirpath to fix the failure in kyua test sys/audit/inter-process:shm_unlink_success.

I'll commit the change.

Apr 12 2022, 4:11 PM
dab accepted D34885: Extending the length of dirpath to fix the failure in kyua test sys/audit/inter-process:shm_unlink_success.
Apr 12 2022, 3:33 PM

Feb 23 2022

dab accepted D34354: rtsold: Use correct error in llflags_get().
Feb 23 2022, 4:51 PM

Dec 28 2021

dab accepted D33667: atrtc: reads Century field from FADT table.

LGTM

Dec 28 2021, 7:12 PM · x86

Oct 11 2021

dab committed rGe72fce241f88: RPCBIND: skip ipv6 link local when request is not from link local address.
Oct 11 2021, 7:07 PM
dab committed rG7ee00acd40bf: RPCBIND: skip ipv6 link local when request is not from link local address.
Oct 11 2021, 5:39 PM

Oct 4 2021

dab closed D31491: Rpcbind: skip ipv6 link local if a request doesn't come from link local address.
Oct 4 2021, 5:47 PM
dab committed rGd18c9a919795: RPCBIND: skip ipv6 link local when request is not from link local address.
Oct 4 2021, 5:47 PM
dab added a comment to D31491: Rpcbind: skip ipv6 link local if a request doesn't come from link local address.

I'll go ahead and commit.

Oct 4 2021, 3:43 PM
dab committed rG50c20d90f97f: ntb_hw_intel: fix xeon NTB gen3 bar disable logic.
Oct 4 2021, 2:07 PM
dab committed rG52e1406947b4: ntb_hw_intel: fix xeon NTB gen3 bar disable logic.
Oct 4 2021, 1:55 PM

Sep 27 2021

dab committed rGe3cf7ebc1d36: ntb_hw_intel: fix xeon NTB gen3 bar disable logic.
Sep 27 2021, 7:15 PM

Aug 30 2021

dab accepted D31491: Rpcbind: skip ipv6 link local if a request doesn't come from link local address.
Aug 30 2021, 12:44 PM

Jun 30 2021

dab accepted D30962: veriexec: fix two compat issues in kernel manifest parser.
Jun 30 2021, 3:26 PM
dab added a reviewer for D30960: veriexec: handle VE_FINGERPRINT_IGNORE from vectx_open: dab.
Jun 30 2021, 3:02 PM
dab added inline comments to D30960: veriexec: handle VE_FINGERPRINT_IGNORE from vectx_open.
Jun 30 2021, 3:01 PM

Jun 9 2021

dab committed rGfe58db828934: pciconf: Fix up pciconf -lc output.
Jun 9 2021, 4:20 PM
dab committed rG7f06d6f3fdde: pciconf: Fix up pciconf -lc output.
Jun 9 2021, 4:19 PM
dab committed rG80a5d786a3cd: libsa: Fix infinite loop in bzipfs & gzipfs.
Jun 9 2021, 4:17 PM
dab committed rG3045f4aa1a2b: libsa: Fix infinite loop in bzipfs & gzipfs.
Jun 9 2021, 4:15 PM

Jun 1 2021

dab committed rG3df4c387d2e3: libsa: Fix infinite loop in bzipfs & gzipfs.
Jun 1 2021, 4:09 PM
dab closed D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
Jun 1 2021, 4:08 PM
dab committed rG2f176a2b2010: pciconf: Fix up pciconf -lc output.
Jun 1 2021, 3:56 PM
dab closed D30441: pciconf: Fix up pciconf -lc output.
Jun 1 2021, 3:56 PM

May 26 2021

dab added inline comments to D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
May 26 2021, 12:29 PM

May 25 2021

dab added inline comments to D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
May 25 2021, 10:04 PM
dab updated the diff for D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
  • Fix typo
May 25 2021, 10:03 PM
dab updated the test plan for D30441: pciconf: Fix up pciconf -lc output.
May 25 2021, 1:14 PM
dab updated the summary of D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
May 25 2021, 1:49 AM

May 24 2021

dab updated the test plan for D30441: pciconf: Fix up pciconf -lc output.
May 24 2021, 8:50 PM
dab retitled D30441: pciconf: Fix up pciconf -lc output from Fix up pciconf -lc output
May 24 2021, 7:20 PM
dab requested review of D30441: pciconf: Fix up pciconf -lc output.
May 24 2021, 7:18 PM
dab updated the diff for D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
  • Shorten comment
May 24 2021, 5:30 PM
dab requested review of D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
May 24 2021, 5:27 PM

Apr 29 2021

dab accepted D29993: EFI secure boot VECTX related changes.
Apr 29 2021, 4:30 PM
dab accepted D30007: ipmi: support getting address from EFI.
Apr 29 2021, 2:44 PM

Apr 27 2021

dab requested changes to D30007: ipmi: support getting address from EFI.

Looks good; just a few style nits.

Apr 27 2021, 1:46 PM

Apr 26 2021

dab accepted D29993: EFI secure boot VECTX related changes.
Apr 26 2021, 3:33 PM

Apr 6 2021

dab accepted D29606: uefisign: handle empty sections.
Apr 6 2021, 3:48 PM

Apr 2 2021

dab accepted D29276: smbios: support getting address from EFI.
Apr 2 2021, 4:15 PM

Mar 31 2021

dab added a comment to D29276: smbios: support getting address from EFI.

Looks pretty good. I would agree that it should be tested on a LEGACY (non-UEFI) BIOS.

Mar 31 2021, 6:22 PM
dab accepted D29512: Loader: support booting OS from memory disk (MD).

LGTM

Mar 31 2021, 3:21 PM
dab accepted D29270: ipmi,smbios: move smbios_walk_table to smbios.h.

LGTM

Mar 31 2021, 1:59 PM

Oct 22 2020

dab added a reviewer for D26895: db_search_symbol: prevent pollution from bogus symbols: dab.
Oct 22 2020, 1:55 AM
dab added a comment to D26895: db_search_symbol: prevent pollution from bogus symbols.

Seems reasonable, although I think the explanation from your description of this change should really go in the code comment rather than the rather terse and enigmatic "Prevent pollution from bogus symbols".

Oct 22 2020, 1:54 AM

Oct 1 2020

dab accepted D26616: zgrep: fix exit status with multiple files.
Oct 1 2020, 1:30 AM

Sep 29 2020

dab committed rS366262: MFC r365967:.
Sep 29 2020, 5:10 PM
dab committed rS366261: MFC r365948:.
Sep 29 2020, 4:39 PM
dab committed rS366255: MFC r365946:.
Sep 29 2020, 3:00 PM

Sep 21 2020

dab committed rS365967: Whitespace fix after r365948.
Sep 21 2020, 6:34 PM
dab committed rS365948: Honor the FWUG value of some drives in nvmecontrol.
Sep 21 2020, 3:46 PM
Next