In D54720#1251266, @siva wrote:

Thanks! Although I don't have a ports commit bit yet, so you'll have to do it :)

Thanks, feel free to merge!

Looks good, a couple of minor questions.

Fix ident.

Thanks, comments resolved.

get_config_value_node(nvl, "mtu"); -> get_config_value_node(config, "mtu");

s/SLIRP_MTU/DEFAULT_MTU/.

Drop unnecessary include.

Pass MTU to slirp-helper as an integer.

In D54133#1246073, @markj wrote:

In D54133#1245938, @novel wrote:

In D54133#1245871, @markj wrote:

We shouldn't modify the config tree in net_backend_slirp.c. Is there something else we can do?

Do you mean the nvlist_clone() part for setting vmname? If so, could that be passed as a part of argv to bhyve-slirp-helper?

Oh, I missed that we do that. In that case, can we please unconditionally pass along the MTU to the helper process so that it doesn't need to define a default?

Drop the DEFAULT_MTU constant from the SLIRP code:

In D54133#1245871, @markj wrote:

We shouldn't modify the config tree in net_backend_slirp.c. Is there something else we can do?

• SLIRP_MTU -> DEFAULT_MTU
• unsigned long -> size_t for mtu values
• move buf allocation before mevent_add_disabled(), update "err" cleanup routines to free() it

Relatively simple way to trigger this error is to run kldunload nmdm and then run bhyve -c 1 -o bootrom=/usr/local/share/u-boot/u-boot-bhyve-arm64/u-boot.bin -o console=/dev/nmdmFoobarA test.

Rebased on top of commit daef625cf884, works fine now.