Adding the wider powerpc umbrella, so others can take a look as well.

the "extint-gpio1" check returned NULL

The type NULL checks are good. I think the whole of the changes for pmu_send() are a bit overkill. Could you test with just the one line I pointed out, and the rest reverted?

In D54639#1248394, @imp wrote:

You could combine the two lines too by

OFFSET=$((0x$(hd...) ))

You could combine the two lines too by

OFFSET=$((0x$(hd...) ))

I can make the case both ways... so either is fine for me.

option #2, thanks warner! this is cleaner!

Impressive

(no changes planned, please review!)

FYI, all other arches unconditionally STAILQ_INIT() the list in allocated maps. 32-bit arm initializes the list twice which is somewhat confusing.

Should this also be applied to stand/powerpc/boot1.chrp/bootinfo.txt?

Recently got this patch working on 13.1, quiets the fans down on my Late 2003 PowerBook5,2. In fact the fans are barely on as far as I can tell, I'll have to investigate temperatures.

This was superseded by https://reviews.freebsd.org/D36420

In D36234#835283, @alfredo wrote:

Make this change powerpc* only in order to unbreak pfsync module and
the test infrastructure.

I'm also seeing this issue when zfs tries to mount my partition.

Considering PowerPC has been broken for quite some time, this seems a good approach, while the real issue on LLD or the kernel linker is not resolved.

Make this change powerpc* only in order to unbreak pfsync module and
the test infrastructure.

In D36234#822496, @markj wrote:

This is rather strange. The description makes it sound like there is a bug somewhere in powerpc relocation handling, nothing specifically to do with cpuset code.

working with gsoc student on ppc64 Linuxulator we see the same relocation problem with copyin/copyout calls from loadable modules

In D36234#822496, @markj wrote:

This is rather strange. The description makes it sound like there is a bug somewhere in powerpc relocation handling, nothing specifically to do with cpuset code.
Until the problem is better understood, I don't think it's appropriate to commit something like this - how do you know that the bug won't require another workaround next week?

This is rather strange. The description makes it sound like there is a bug somewhere in powerpc relocation handling, nothing specifically to do with cpuset code.

I think this is fine as is.
There's no need to check for nfs in the middle of a string, unless there's some use case I'm unaware of...

In D33603#796461, @alfredo wrote:

I like the idea! However I burned an DVD for a PowerBook G4 and I only see the regular disc icon.
What's your device model? (based on other sources your patch looks correct. Maybe my firmware is too old for this feature)

Seems legit

I like the idea! However I burned an DVD for a PowerBook G4 and I only see the regular disc icon.
What's your device model? (based on other sources your patch looks correct. Maybe my firmware is too old for this feature)

It really needs someone familiar with bootstrapping to review this.
(Except for being the nfs case, it really has nothing to do with nfs.)

@rmacklem, 'vfs.root.mountroot' is used as a kernel parameter to specify (or override) where is the root filesystem to be mounted and its partition type. It's usually something like "vfs.root.mountroot=ufs:/dev/da0s1a" if you use a local disk, or "vfs.root.mountroot=nfs:192.168.0.1:/tftpboot/root" if using nfs.

use strncmp instead of strstr in order to match only the beginning of the string

Beyond changing strstr() to a check for "nfs:" at the beginning of the
string, as suggested by sjg@, I don't see a problem with this.

Anything new on this?

edit: commented on wrong revision

Suspending this since it requires changes to continue.
The OS revision part is now being discussed in D34429.

Abandoned due to https://cgit.freebsd.org/src/commit/?id=298c3e8d6b6405cbea13a7a1a1fbc1ad5a45c378

You may cherry pick https://github.com/llvm/llvm-project/commit/53fc5d9b9a0110f097c6e9f7aa3bff3621eaf268 to avoid the local changes.

Or maybe not, I can see some ARM configs also have this, along with comment [KEEP THIS!].

sys/powerpc/conf/MPC85XXSPE also includes COMPAT_43. That should also be removed.

Looks good.

add ports package versions and adjust comments

looking better! Thanks for splitting out the style changes.
Just a couple of bits of feedback for comments.

• style change commited with hash 8d1ab5ad8449e6f51f081e261ed6202a0483a595
• removed COMPAT_FREEBSD8 from config files, since it doesn't exist.

Makes sense. In that case, I think this is good

In D33421#755638, @imp wrote:

Also, I thought that we broke powerpc bin-compat with ELFv2. if so, all these lists are way too long :)

I'd be sorely tempted to commit the style changes separately.
Also, I thought that we broke powerpc bin-compat with ELFv2. if so, all these lists are way too long :)

updated after discussion on IRC