I'd argue that portclippy is wrong, don't mix GITHUB with the rest of USES section it makes harder to follow and preferably put it in a separate section below like in Porters Handbook.
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

In D52304#1194191, @michaelo wrote:

In D52304#1194190, @diizzy wrote:

You might want to add a refence?

You mean https://github.com/freebsd/freebsd-src/blob/fb37e38fbe99039a479520b4b596f4bfc04e2a88/usr.sbin/bsdinstall/scripts/zfsboot#L52-L54?

You might want to add a refence?

Not sure if https://www.w1hkj.org/files/flrig/ is all that useful as it seems to drop legacy versions

Ping and you probably also want to backport, https://github.com/Thalhammer/jwt-cpp/commit/cf0dab12633bb6c39ae7a7fe147b3d2fb7b3f047

Perhaps also reference upstream PR?

Comment out this line, https://github.com/vchimishuk/loderunner-ng/blob/master/CMakeLists.txt#L24

The interface name awg is already taken, https://cgit.freebsd.org/src/tree/sys/arm/allwinner/if_awg.c?h=releng/14.3

Any attempts of upstreaming?

I'd value consistency over granuality that adds complexity but that's a personal opinion. If it works and Poudriere is happy I don't have any objections. Mentors?

LGTM

Done, https://cgit.freebsd.org/ports/commit/?id=b125360a0b37b795731ed50ec2cbaf68c902e19c :-)

In D51019#1164454, @ehaupt wrote:

The current version does not fetch. If you insist on removing the GL_ stuff (though I don't see the point—aside from dizzy fighting his personal war against convenient git references), please test with make distclean; make fetch. Also, please run portfmt -i on the Makefile.

lgtm,
While out of scope you should be able to remove GL_TAGNAME and replace PORTVERSION with DISTVERSION

To be fair I'd argue for that unless there a switch/toggle provided by upstream we always install manpages unless they have dependencies.

Yes, that should be fine in most cases.

Either way is fine, if you want minimal impact however.... (a bit hackish) :-)